1. Forum
  2. DOVE-Net
  3. Synchronet Sysops

  • April commit breaks ansiview

    From Nigel Reed@VERT to GitLab issue in main/sbbs on Wed May 1 22:59:39 2024
    open https://gitlab.synchro.net/main/sbbs/-/issues/752

    By using git bisect I was able to determine the following commit broke the lightbar in ansiview, but only on the first page.

    ```
    commit 8eef2dc8294a551009f2ee63b92aa14983b0b811 (HEAD, refs/bisect/bad)
    Author: Rob Swindell (on Debian Linux) <rob@synchro.net>
    Date: Thu Apr 25 23:00:46 2024 -0700
    ```

    There is no highlighted bar after this commit.

    Either that is it 'fixes' something that is now showing as broken within ansiview.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Thu May 2 12:38:02 2024
    https://gitlab.synchro.net/main/sbbs/-/issues/752#note_5316

    Thank you! Good find (and the bisection report saves me a lot of time!).

    It appears to be the result of the change to `attrstr` (now called `strtoattr`) which stops parsing when reaching an invalid attribute character (but before would continue parsing, just ignoring invalid attribute characters).

    So something in `tree.js` or one its dependent scripts must be setting an invalid attribute character. :-( I'll have to dig a little more later to find out why/what.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Nigel Reed@VERT to GitLab note in main/sbbs on Thu May 2 13:18:54 2024
    https://gitlab.synchro.net/main/sbbs/-/issues/752#note_5317

    Full credit to Dan_C for spotting the issue. I did the laborious job of hunting down the commit.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Nigel Reed@VERT to GitLab note in main/sbbs on Thu May 2 14:58:20 2024
    https://gitlab.synchro.net/main/sbbs/-/issues/752#note_5318

    What sort is thing would we be looking for?

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to GitLab note in main/sbbs on Thu May 2 15:06:42 2024
    https://gitlab.synchro.net/main/sbbs/-/issues/752#note_5319

    Assignments of strings (that contain invalid attribute characters) to `console.attribute` most likely.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Nigel Reed@VERT to GitLab note in main/sbbs on Thu May 2 16:14:35 2024
    https://gitlab.synchro.net/main/sbbs/-/issues/752#note_5320

    tree.js only includes funclib.js and that itself only includes sbbsdefs.js upon certain conditions.
    Maybe it's another of the included files in ansiview.js ?

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From echicken@VERT to GitLab issue in main/sbbs on Thu May 2 20:25:46 2024
    close https://gitlab.synchro.net/main/sbbs/-/issues/752

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net