https://gitlab.synchro.net/main/sbbs/-/commit/3d5feda5b2f1ae5e9a2b7fd9
Modified Files:
src/sbbs3/ftpsrvr.cpp sbbsecho.c src/sbbs3/scfg/scfg.c scfg.h scfgmsg.c scfgsub.c scfgxfr2.c src/sbbs3/uedit/uedit.c src/sbbs3/umonitor/umonitor.c
Log Message:
Size the buffers that receive an scfg_t system directory path
af6907bf22 (pads-5-visit, 2026-09-09) grew the scfg_t directory fields
from 100 to 1023 bytes, so every buffer one of those is printed into now
has to be able to hold it. GCC reports 31 -Wformat-overflow sites where
it cannot: the FTP server's ctrl_thread(), sbbsecho's NetMail export,
SCFG's shared tmp[] and three of its menu functions, uedit's comment
editor, and twenty places in umonitor.
Size those destinations MAX_PATH + 1, the convention the same functions
already use for their other path buffers. Every one is an increase:
uedit and umonitor build only on *nix, where MAX_PATH is PATH_MAX
(4096), and the rest were 128 or 256 bytes, below the 260 that MAX_PATH
is on Windows.
sbbsecho built its mail base path with a bare sprintf() into
smb_t.file[128]; use SAFEPRINTF(), as the twenty-odd other sites that
populate that field do. All of them still truncate a data_dir longer
than 127 characters. Widening smb_t.file is an smblib ABI change and is
not done here.
Co-Authored-By: Claude Opus 5 (1M context) <
noreply@anthropic.com>
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net