1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/useredit.cpp

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 8 22:29:46 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/8ae00a5795ce733593c2c4ef
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Clean up the sbbs_t::console (JS console.status) bit flags

    Mainly this is renaming CON_R_ECHOX to CON_PASSWORD, but also eliminating several long-unused flags.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Dec 30 16:39:35 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/e891fb86becbb3f383eb47e2
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Remove the user (defaults) config menu that is now handled in user_settings.js

    Since the user config mod defaults to this script name (if blank), there
    was really no way to revert to the hard-coded logic any more anyway.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed May 6 22:36:57 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/8d4a10dfb54ef3d9108a829b
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    useredit: log error if user_config getuserdat fails (CIDs 516411, 530902)

    After invoking the external user-config module the in-memory user_t
    needs to be re-read; if getuserdat fails the caller proceeds with
    stale data. Log the error like purgeuser() already does.

    CID 516411 was originally reported against the now-removed maindflts() function; it appears to have been merged into user_config(), so the
    single fix covers both CIDs.

    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jul 28 14:27:05 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/7ad244479109ee15f456a253
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    uedit: free search expressions on early loop exit (CID 651709)

    Coverity CID 651709 (RESOURCE_LEAK): "Variable find_expr going out of
    scope leaks the storage it points to", at useredit.cpp:108.

    sbbs_t::useredit() releases both of its heap allocations -- 'ar' (the
    '/' ARS search) and 'find_expr' (the 'T' boolean text search) -- in the
    'Q'uit case and again after the display/command loop. Two returns
    inside the loop skip that cleanup: the "no user data" bail-out, and the localtime32() failure Coverity flagged. The loop redraws the record on
    every pass, so both are reachable after a search has been entered, and
    both leak 'ar' as well as 'find_expr'.

    Break out of the loop instead of returning, so the existing cleanup
    runs. Behavior is otherwise unchanged.

    find_expr, and the free(ar) at the loop exit, are from ef1f8026a4
    (2026-07-25); the 'ar' leak on these two paths predates it.

    Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net