• src/sbbs3/xtrn.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Jun 15 09:09:25 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/e54263fde0be580dcbaf77c8
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Log command-line that led to logged error opening DOSXTRN.RET

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Jul 2 22:22:07 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/280f16f4f373956c17d2a5eb
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Add EXECDIR, DATADIR, and XTRNDIR to DOSemu command replacement tokens

    As requested. This closes issue #416

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Jul 6 18:23:10 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/ce475f794e112fa9c9f435c6
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Don't log error opening DOSXTRN.RET when terminating an external

    If we detect a client disconnection and terminate DOSXTRN.EXE, don't try to open DOSXTRN.RET and log an error when the file doesn't exist (as would be expected).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Oct 7 18:42:19 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/e7109c87bc43f21636c5f981
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    When user hangs-up on external programs on *nix, try to terminate w/SIGTERM

    Previously, when a user disconnected or ran out of time while running a stdio-based external program on *nix, if the program was still running, we'd send it a SIGHUP, wait up to 10 seconds for the process to terminate and if
    it did not, terminate it (ungracefully) with SIGKILL. Since some programs
    catch SIGTERM (and not SIGHUP) to indicate a termination request, we now will first attempt a SIGHUP, wait up to 5 seconds for the process to terminate and if it does not, then send a SIGTERM and wait up to another 5 seconds for it
    to terminate and if it doesn't, then finally send it a SIGKILL (which cannot
    be caught and always results in an ungraceful termination of the child process).

    This doesn't resolve any specific problem with any specific stdio-based external program, but I was playing around with ESR's port of Adventure (https://gitlab.com/esr/open-adventure) and a new auto-save/restore of game state and noticed that we weren't using SIGTERM for this situation, though we should have. Most modern programs, if they catch SIGHUP at all, use it to indicate a refresh of configuration or data files, not a termination request (or indication that a user has "hung up"). So SIGTERM is more reasonable to be expected to be caught and initiate the graceful termination of the child program that we're hoping for.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Thu Dec 29 09:35:16 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/f78a70986d1e3b21b09ca32e
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Fix name of data event

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Jan 25 10:29:48 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/23513871ebc07d81e7cb83d8
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    0-init the 'gamedir' variable

    Resolves CID 434888, not sure why this one didn't show up before.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Nov 10 21:03:12 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/47773812d5d779c3a2d5466a
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Eliminate unsafe sprintf calls (replaced with snprintf) in *nix build

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Dec 8 23:03:47 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/90de66ac9910333dfdf76d98
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Move the startup directory checking to the "native" block of *nix build

    of sbbs_t::external()

    The startup directory for DOS doors might not be a valid Unix (case-sensitive) path, so let's just do that check in the native block here.

    Also, removed a bunch of redundant startup_dir ==/!= NULL checks. It can't be NULL here.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Feb 12 14:07:17 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/241475effe9d6c09d677b323
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Since on at least Debian 12.4, the ttydefaults array is completely
    wrong, do c_cc the stupid (but POSIXly correct) way with a billion
    supporting.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Feb 12 14:26:47 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/d1642fb88cf3d8ac38c6d8e2
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Explicitly initialize c_cc to _POSIX_VDISABLE since we can't know
    that we're setting all the values anymore. :(

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Mon Feb 12 14:54:00 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9db2d372ed865d17b7fb4ce2
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Don't use i for loop index since it's signed.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Apr 26 17:11:49 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/40280934edd931d5d3516b7e
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Convert CP437 to UTF-8 (when necessary) for *nix stdio doors (e.g. DOSEMU)

    ... as requested by "ben" in #synchronet at irc.synchro.net

    Currently, this assumes all stdio doors aren't "UTF-8 native", which might be an incorrect assumption.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Apr 26 17:25:56 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5277021c97929fc46c742093
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Fix GCC-aarch64 compile (caught be pipeline)

    error: cannot bind non-const lvalue reference of type ‘long unsigned int&’ to an rvalue of type ‘long unsigned int’

    Just getting rid of more use of ulong (replaced with size_t).

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Apr 26 19:16:06 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/da313d28ca8be77e28f96d8e
    Modified Files:
    src/sbbs3/xtrn.cpp
    Log Message:
    Fix MSVC compiler issues introduced in previous commit

    And use DWORD insteaad of 'unsigned long' where specified by Win32 API.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net