1. Forum
  2. Fidonet
  3. SYNC PROGRAMMING

  • DDFileLister: Sanitize file descriptions to remove control characters

    From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Wed Dec 24 20:24:20 2025
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/590#note_7989

    You seem to be reinventing the wheel here. See `strip_ctrl()` in the Synchronet global JS object.
    --- SBBSecho 3.33-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Wed Dec 24 20:46:06 2025
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/590#note_7990

    But strip_ctrl() also removes Ctrl-A characters. I don't want to remove any Synchronet attribute/color codes in case a file description has any.
    --- SBBSecho 3.33-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Thu Dec 25 01:34:44 2025
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/590#note_7992

    Okay, that is true. It's a little strange that you call String.replace() repeatedly rather than using a regexp that replaces all occurrences of either problematic character.

    In case, I'm fine to approve for merge.
    --- SBBSecho 3.33-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Thu Dec 25 07:55:40 2025
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/590#note_7996

    I think I should update this to remove other problematic characters too. At the time I wrote this, I had added a file to a file directory I have that has these two problematic characters, but I suppose there are more that could pose issues.
    --- SBBSecho 3.33-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)